Epitech/T-IOT-901_convoyor
4
0
Fork 0
Code Issues 4 Pull Requests Packages Projects 1 Releases Wiki Activity

feat: nfc-reader #15

Merged
Clement merged 5 commits from feat/nfc-reader into develop 2024-01-19 11:01:18 +00:00
Conversation 3 Commits 5 Files Changed 5 +2581
Clement commented 2023-11-17 15:25:02 +00:00
Owner
Copy Link
<!-- Bravo pour la PR, quelque note pour que tout se passe au mieux :D - Lier la PR a une issue si elle existe! - Assurez-vous que le nom de la PR respecte les règles (voir CONTRIBUTING.md) - faites des rebase pour valider la PR - Assurez-vous que le CI/CD est au vert -->
Clement added 4 commits 2023-11-17 15:25:04 +00:00 
<!--
Bravo pour la PR, quelque note pour que tout se passe au mieux :D

- Lier la PR a une issue si elle existe!
- Assurez-vous que le nom de la PR respecte les règles (voir CONTRIBUTING.md)
- faites des rebase pour valider la PR
- Assurez-vous que le CI/CD est au vert
-->

Co-authored-by: Clement <c.boesmier@aptatio.com>
Reviewed-on: #12
Co-authored-by: Nicolas SANS <nicolas.sansd@gmail.com>
Co-authored-by: Clement <c.boesmier@aptatio.com>
Co-authored-by: Clement <clement@jo85.com>
Reviewed-on: #7
Co-authored-by: Nicolas <nicolas.sansd@gmail.com>
Co-committed-by: Nicolas <nicolas.sansd@gmail.com>
Nicolas changed title from WIP: feat: nfc-reader to WIP: feat: nfc-reader 2023-12-21 09:57:11 +00:00
Nicolas changed target branch from master to develop 2023-12-21 09:57:12 +00:00
Gildas added 1 commit 2024-01-18 15:57:44 +00:00
Clement added a new dependency 2024-01-18 18:48:59 +00:00
#16 feat: main-algo
Clement reviewed 2024-01-18 18:57:19 +00:00
Clement left a comment
Author
Owner
Copy Link

2/3 truc a changé

2/3 truc a changé
lib/NFC/src/NfcReader.hpp Outdated
@ -0,0 +1,28 @@
/*
Clement commented 2024-01-18 18:56:46 +00:00
Author
Owner
Copy Link

le fichier est en HPP et non en H

le fichier est en HPP et non en H
Gildas marked this conversation as resolved
lib/NFC/src/NfcReader.hpp Outdated
@ -0,0 +1,28 @@
/*
** EPITECH PROJECT, 2024
Clement commented 2024-01-18 18:55:25 +00:00
Author
Owner
Copy Link

on a pas mis de header sur les autre fichier

on a pas mis de header sur les autre fichier
Gildas marked this conversation as resolved
lib/NFC/src/NfcReader.hpp Outdated
@ -0,0 +15,4 @@
class NfcReader {
public:
NfcReader(int i2c_adress);
~NfcReader();
Clement commented 2024-01-18 18:55:44 +00:00
Author
Owner
Copy Link

On n'a pas mis de destructeur non plus

On n'a pas mis de destructeur non plus
Gildas marked this conversation as resolved
Clement commented 2024-01-18 19:02:33 +00:00
Author
Owner
Copy Link

ajouter NFC_ADDR dans les config

ajouter NFC_ADDR dans les config
Clement changed title from WIP: feat: nfc-reader to feat: nfc-reader 2024-01-19 10:46:38 +00:00
Gildas added 1 commit 2024-01-19 10:49:12 +00:00
Clement added 1 commit 2024-01-19 10:52:03 +00:00
Clement reviewed 2024-01-19 10:53:08 +00:00
Clement left a comment
Author
Owner
Copy Link

on est good

on est good
lib/NFC/src/NfcReader.cpp
@ -0,0 +20,4 @@
this->uid.clear();
if (!this->mfrc522->PICC_IsNewCardPresent() ||
!this->mfrc522->PICC_ReadCardSerial()) {
delay(200);
Clement commented 2024-01-18 19:42:07 +00:00
Author
Owner
Copy Link

delay vraiment util ?

delay vraiment util ?
Gildas marked this conversation as resolved
Clement added 1 commit 2024-01-19 10:54:27 +00:00
Gildas added 1 commit 2024-01-19 10:58:18 +00:00
Clement merged commit 6e9a59bb00 into develop 2024-01-19 11:01:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Scope
API
Scope
IoT
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#16 feat: main-algo
Epitech/T-IOT-901_convoyor
Reference: Epitech/T-IOT-901_convoyor#15
No description provided.
Delete Branch "feat/nfc-reader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?